Closed Blacksmoke16 closed 1 year ago
@Blacksmoke16 Have you tested the artifacts from the CI workflow to ensure JIT compilation is working?
Seems like it is:
jit_enabled = uninitialized UInt32
LibPCRE2.config LibPCRE2::CONFIG_JIT, pointerof(jit_enabled)
pp jit_enabled
$ ./crystal-ci-update-distribution-scripts-pcre2-jit-dev-1/bin/crystal run -Duse_pcre2 test.cr
1
While before from https://app.circleci.com/pipelines/github/crystal-lang/crystal/11516/workflows/1be479c4-9fa7-4c5c-bed0-6cc779c784c6/jobs/75135, it is:
$ ./crystal-1.8.0-dev-1/bin/crystal run test.cr
0
Also I can't remember if its expected or not, but none of the 1.7.x
tarballs have pcre2-8
within the embedded/lib
directory so it fails when using -Duse_pcre2
, so technically you couldn't use it to test at all.
Thanks, then we can merge this.
Also I can't remember if its expected or not, but none of the
1.7.x
tarballs havepcre2-8
within theembedded/lib
directory so it fails when using-Duse_pcre2
, so technically you couldn't use it to test at all.
Yes, that's expected. You need to install it explicitly.
Yes, that's expected. You need to install it explicitly.
But the catch is I do have pcre2
installed explicitly, but won't it not be able to find it due to the lib path pointing at that single directly that doesn't have it?
CRYSTAL_LIBRARY_PATH
is not exclusive. It goes on top of any other library paths configured with the system/linker. As long as ld
is able to find the library somewhere, you should be good.
omnibus/vendor
to.gitignore
Omnibus successfully built PCRE2 on my mac with this change:
But the build ultimately failed, for I'd assume due to an unrelated/known issue:
Resolves #228