search

crystal-lang / distribution-scripts

40 stars 24 forks source link

Use universal darwin build for previous crystal #266

Open miry opened 10 months ago

miry commented 10 months ago

For last few crystal releases there is only crystal-darwin-universal. It means, there is no need to separate on ARCH in Makefiles or folder names for darwin.

Update darwin/Makefile to use folder name without arch suffix.

Example usage:

make -C darwin CRYSTAL_VERSION=1.10.1 PREVIOUS_CRYSTAL_RELEASE_DARWIN_TARGZ=https://github.com/crystal-lang/crystal/releases/download/1.10.1/crystal-1.10.1-1-darwin-universal.tar.gz

my level of understanding the whole process: noob

straight-shoota commented 10 months ago

CI workflow run: https://app.circleci.com/pipelines/github/crystal-lang/crystal/13351/workflows/0e70450f-675a-4382-98c1-6ec959e61eea

miry commented 10 months ago

checking failed test

miry commented 10 months ago

Updated the code to use crystal-darwin-universal folder name and found a missing spot, where the folder was used.

straight-shoota commented 10 months ago

New CI run: https://app.circleci.com/pipelines/github/crystal-lang/crystal/13356/workflows/5a0c364e-6f0d-40b5-bd29-6095dfb66302

straight-shoota commented 9 months ago

New CI run: https://app.circleci.com/pipelines/github/crystal-lang/crystal/13882/workflows/ab68057e-075c-43b8-96a2-8e5b2db11597