search

crystal-lang / distribution-scripts

40 stars 24 forks source link

MacOS target 11.0 #270

Closed miry closed 9 months ago

miry commented 10 months ago

pcre2 warning message shows, that it could be compiled against 11.0

./src/sljit/sljitExecAllocator.c:154:2: warning: 'pthread_jit_write_protect_np' is only available on macOS 11.0 or newer [-Wunguarded-availability-new]
        pthread_jit_write_protect_np(enable_exec);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/pthread.h:588:6: note: 'pthread_jit_write_protect_np' has been marked as being introduced in macOS 11.0 here, but the deployment target is macOS 10.11.0

Bump Macos target to 11.0.

PS: It shows on my machine, and does not mean it is the same for other places.

straight-shoota commented 10 months ago

CI workflow run: https://app.circleci.com/pipelines/github/crystal-lang/crystal/13354/workflows/5de8024f-c562-4198-b87a-5b7d40e33ce3

HertzDevil commented 10 months ago

Does this have anything to do with https://github.com/crystal-lang/crystal/blob/f8fafc386c4fae7ac50a7577df22d4aadb788852/shell.nix#L149?

straight-shoota commented 10 months ago

No. Omnibus and Nix shell are completely unrelated.