search

crystal-lang / distribution-scripts

40 stars 24 forks source link

Release Crystal 1.12.2 #308

Closed straight-shoota closed 5 months ago

straight-shoota commented 5 months ago

Release preparation

  1. [x] Prepare the changelog entry: crystal:scripts/github-changelog.cr
  2. [ ] Start preparing release notes
  3. [x] Publish release PR draft
    • It should be populated with updates to CHANGELOG.md and VERSION.
  4. [x] Ensure that test-ecosystem functions and succeeeds on master

Release process

Source release

  1. [x] Finalize the release PR
    • Make sure all changes are mentioned in the changelog
    • Check release date
    • Un-draft the PR
  2. [x] Verify Maintenance CI workflow succeeds on the HEAD of the release branch
  3. [ ] Smoke test with test-ecosystem
  4. [x] Merge the release PR
  5. [x] Make the release and publish it on GitHub: ../distribution-scripts/processes/scripts/make-crystal-release.sh (run from crystallang/crystal@$VERSION work tree). This performs these steps:
    1. Tag & annotate the commit with the changelog using <M.m.p> pattern as version
      • git tag -s -a -m $VERSION $VERSION
      • git push --tags
    2. Publish Github release (https://github.com/crystal-lang/crystal/releases/new)
      • Copy the changelog section as description
      • Binaries are added later
  6. [x] Close milestone (https://github.com/crystal-lang/crystal/milestones)
  7. [x] Wait for the release build in circle CI (https://app.circleci.com/pipelines/github/crystal-lang/crystal)

Binary releases

  1. Publish build artifacts from CircleCI and GitHub Actions to GitHub release. For URL_TO_CIRCLECI_ARTIFACT grab the URL of any of the build artifacts in circleCI (doesn't matter which).
  2. [x] Push changes to OBS for building linux packages
    1. Checkout https://github.com/crystal-lang/distribution-scripts and go to ./packages
    2. Configure build.opensuse.org credentials in environment variables:
      • export OBS_USER=
      • export OBS_PASSWORD=
    3. Update the crystal${VERSION%.*} package: ./obs-release.sh devel:languages:crystal crystal${VERSION%.*} $VERSION
    4. Now OBS builds the packages. It’s best to follow the build status in the browser:
      1. open https://build.opensuse.org/project/show/home:$OBS_USER:branches:devel:langauges:crystal/crystal
      2. Wait for all package build jobs to finish and succeed
    5. When everything is green, create a submit request against the original packages (Submit package link in the menu bar on the package in your branch)
    6. Verify package installation
      • OBS_PROJECT=devel:languages:crystal bats test
  3. [x] Tag latest docker images
    • Versioned docker images have been pushed to dockerhub.
    • Now just assign the latest tags:
    • ./docker/apply-latest-tags.sh ${VERSION}
  4. [x] Publish snap package (you can use the docker image snapcore/snapcraft for running the following commands)
    1. docker run --pull=always --rm -it snapcore/snapcraft
    2. You need to logged in via snapcraft login
    3. Recent tagged release is published directly to edge channel. The CI logs the snap revision number. Otherwise the .snap file is in the artifacts.
    4. Check the current status to find the revision of the tagged release otherwise:
    5. snapcraft status crystal
    6. snapcraft release crystal <revision-number> beta
    7. snapcraft release crystal <revision-number> stable
  5. [ ] Check PR for homebrew: https://github.com/Homebrew/homebrew-core/pulls?q=is%3Apr+crystal+sort%3Aupdated-desc
    • It should've been automatically created

Publish documentation for the release

  1. [x] Publish API docs
    1. Have AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY env variables defined
    2. Run make -C docs publish_docs dist-redirect_latest CRYSTAL_VERSION=${VERSION} to publish docs to api/${VERSION} and apply redirect from api/latest to api/${VERSION}

Release announcements

  1. [x] Publish release notes on the website
  2. [x] Post announcement in https://forum.crystal-lang.org/c/news/official
  3. [ ] Announce on social media accounts (via Buffer; credentials are in Passbolt) and pin release posts
  4. [ ] Update https://github.com/crystal-lang/crystal-book/blob/master/crystal-version.txt

Post-release

  1. [x] Update crystal master branch to use released version: crystal:scripts/release-update.sh ${VERSION}
    • Edit PREVIOUS_CRYSTAL_BASE_URL in .circleci/config.yml
    • Edit DOCKER_TEST_PREFIX in bin/ci
    • Edit prepare_build on_osx download package and folder
    • Edit .github/workflows/*.yml to point to docker image
    • Edit shell.nix latestCrystalBinary using nix-prefetch-url --unpack <url>
  2. [ ] Update default base version in test-ecosystem: test-ecosystem:scripts/release-update.sh ${VERSION}
  3. [x] Merge release/${VERSION%.*} branch into master (if the two have diverged)
    • This needs to be a merge commit. Those are disabled in the GitHub UI.
    • git switch master && git pull && git merge release/${VERSION%.*}; git checkout master src/VERSION && git add src/VERSION && git commit
    • Double check merge commit history is as expected
    • git push (GitHub branch protection rules normally prevent direct pushes to master. This needs to be deactivated for this purpose, which can be on a per-user basis.)
Blacksmoke16 commented 5 months ago

@straight-shoota Seems no brew PR was created for 1.12.2.

straight-shoota commented 5 months ago

Yeah, this is really stupid: The brew updates are completely automated via BrewTestBot, but it skips updates when there's an open PR concerning the respective formula. https://github.com/Homebrew/homebrew-core/pull/165986 is pending for months now and I have to close it for the updater to do its work, and re-open again afterwards 🤦