search

crystal-lang / distribution-scripts

40 stars 24 forks source link

Add ldd output and wait before touch #37

Closed bcardiff closed 5 years ago

bcardiff commented 5 years ago

Related to #33 .

Sometimes the touch leave the same date as the cc output. The sleep should fix that. I added ldd output to have some additional manual checks during the build.

I'm not sure if this will solve 100% of the issues, but it reduces the chances and the logs have additional diagnosis information.

Maintenance build at https://circleci.com/workflow-run/e2779fd7-c51c-4b53-9e61-a36db574e779

RX14 commented 5 years ago

I'd much prefer to robustly solve this problem by placing the built cross-compiled crystal into PATH, which would solve the problem without hacky delays.

RX14 commented 5 years ago

Alternatively, see if we can avoid cross-compiling completely now, i seem to recall a PR for that but i can't find it, so it's not a near-term solution :(

bcardiff commented 5 years ago

I changed it to use a different path. I left the last ldd as a manual check.

Maintenance build at https://circleci.com/workflow-run/d559bd23-1e8a-41e9-8b17-eb15a4b2ec6d

RX14 commented 5 years ago

Actually, we don't validate the output of ldd so I'd prefer it to be removed. Either check the output of ldd to make sure it's statically linked and fail the build if it's not, or leave it out and run ldd manually for debugging.

bcardiff commented 5 years ago

ok, done.