Remove stackbottom patch

crystal-lang / distribution-scripts

40 stars 24 forks source link

Remove stackbottom patch #42

Closed j8r closed 2 years ago

j8r commented 5 years ago

~Proposing feature-thread-stackbottom.patch to https://github.com/ivmai/bdwgc would be a win for everybody:~

~Crystal core developers won't have to maintain this patch~
~Crystal developers won't have to recompile bdwgc to have this feature, it will be directly available in the OS package~
~bdwgc users will be able to use it~

Edit: the patch is already merged with https://github.com/ivmai/bdwgc/commit/5668de71107022a316ee967162bc16c10754b9ce Remains to remove the patch when a new release of bdwgc will be out.

jhass commented 5 years ago

See https://github.com/ivmai/bdwgc/pull/277

j8r commented 5 years ago

Thanks @jhass . I see that https://github.com/ivmai/bdwgc/commit/5668de71107022a316ee967162bc16c10754b9ce is merged @bcardiff , do you think the patch can now be removed?

bcardiff commented 5 years ago

Until there is no bdwgc release, the only change we could do is use the patch from upstream that has a slightly different signature. It’s something on my radar. It needs to be in sync with crystal master for crystal release.

Definitely something to happen before preview_mt becomes stable.

j8r commented 5 years ago

@jhass I updated the description, can you reopen the issue?

bcardiff commented 4 years ago

The patch was updated with upstream in #47.

We still need this issue open to remove the patch once there is a new release of bdw-gc.