crystal-lang / distribution-scripts

40 stars 24 forks source link

Build linux compiler and shards without debug info #43

Closed bcardiff closed 5 years ago

bcardiff commented 5 years ago

darwin omnibus and homebrew formula compiles the compiler and shards with --no-debug

The CI have been failing lately because due to latest changes somehow seems to hit during the release process in the second stage of the compiler. It seems we are hitting https://github.com/crystal-lang/crystal/issues/4276

One of the exception seems to be https://github.com/crystal-lang/crystal/pull/7334/files#r250621065 from the trace of a build with dprintf and usually the errors in the last couple of days was looks like https://circleci.com/gh/crystal-lang/crystal/28075 .

Until that is solved, this workaround seems to allow the release to keep going.

A maintenance workflow was run at https://circleci.com/workflow-run/c1b9154b-cbb0-4041-ae6b-c7c00709153d

I also tried bumping all dependencies alpine:3.10, debian:9, llvm 8 as an alternative but the error was still there and even with debug information the stack trace seems to have less information https://circleci.com/gh/crystal-lang/crystal/28278

Bonus: there seems that a lot of exceptions are been raised while the compiler is been compiled. That can be viewed at https://circleci.com/gh/crystal-lang/crystal/28301 . Maybe there is something to improve there or to investigate to narrow the issue.

Somehow I couldn't reproduce the issue from Docker in OSX. And bisecting in the CI didn't offer real information to narrow it down.

RX14 commented 5 years ago

I didn't see this PR before I started updating everything to LLVM 8 and simplifying the build process in #44. Perhaps it'll fix it, who knows.

At the least, --no-debug can easilly be added after that PR is merged, but they do conflict (it's easier to fix the merge conflict if #44 is merged first).