Fix APK packages in alpine.Dockerfile

crystal-lang / distribution-scripts

40 stars 24 forks source link

Fix APK packages in alpine.Dockerfile #53

Closed straight-shoota closed 4 years ago

straight-shoota commented 4 years ago

Remove readline-dev because Readline has been removed from stdlib since Crystal 0.32.0
Use proper packages providing libevent, openssl and zlib static libraries. (*-static packages also install *-dev packages

bcardiff commented 4 years ago

Could you remove libreadline-dev from ubuntu.Dockerfile also?

I am not sure the zlib-static will be picked since pkg-config is not available and @[Link("z")] is used for LibZ. But as long as zlib-dev is included it should be fine to start with.

straight-shoota commented 4 years ago

Done.

bcardiff commented 4 years ago

The PR in the main repo can be updated again now. Thanks!