crystal-lang / distribution-scripts

40 stars 24 forks source link

Provide newer Git version in the Docker image #61

Closed oprypin closed 3 years ago

oprypin commented 4 years ago

The current version (which I guess is 2.17.1 from Bionic) causes GitHub Actions to not actually expose the Git repo as a repo but just check out the bare files, which can be a hard-to-debug surprise when people rely on the image in GitHub Actions.

The repository will be downloaded using the GitHub REST API To create a local Git repository instead, add Git 2.18 or higher to the PATH

https://github.com/crystal-lang/crystal/runs/597246816?check_suite_focus=true#step:3:20


I've had to work around this by not using the image and instead installing Crystal with something like snap

straight-shoota commented 4 years ago

I'd simply wait for Ubuntu 20.04 LTS which should be available in about two weaks.

straight-shoota commented 3 years ago

I think this can be considered resolved? We now have the install-crystal action for GitHub actions.