search

crystal-lang / distribution-scripts

40 stars 24 forks source link

Fix alpine Dockerfile to add *-static packages and update to alpine 3.13 #79

Closed straight-shoota closed 3 years ago

straight-shoota commented 3 years ago

Resolves crystal-lang/crystal#10313

bcardiff commented 3 years ago

In https://github.com/crystal-lang/distribution-scripts/pull/68 that was changed here https://github.com/crystal-lang/distribution-scripts/pull/68/files#diff-c306b13048e7d0a5c50f527d9ff3fbcd7deb85a451c5bdad725a10f9e2b2322cL48 but not here https://github.com/crystal-lang/distribution-scripts/blob/master/docker/alpine.Dockerfile#L8

Are you sure you prefer to use different alpine base images while building the binaries and distributing the docker images?

If we want to bump entirely to alpine 3.13 we need to change alpine_image=alpine:3.12 and alpine_image=i386/alpine:3.12 also.

Whatever is decided, I can rebuilt the alpine 0.36 image with these changes and republish it.

straight-shoota commented 3 years ago

In https://github.com/crystal-lang/distribution-scripts/pull/68 that was changed here https://github.com/crystal-lang/distribution-scripts/pull/68/files#diff-c306b13048e7d0a5c50f527d9ff3fbcd7deb85a451c5bdad725a10f9e2b2322cL48 but not here https://github.com/crystal-lang/distribution-scripts/blob/master/docker/alpine.Dockerfile#L8

Yeah, I noticed that, too. We should probably try to avoid this duplication. IIRC there was some effort about unifying both dockerfiles / re-using the alpine dockerfile for the linux build. Would've definitely helped here.

Are you sure you prefer to use different alpine base images while building the binaries and distributing the docker images?

I didn't look into the base image version used for linux build. But I suppose we should probably update that to 3.13 as well.

straight-shoota commented 3 years ago

3.13 sounds better I think.