search

crystal-lang / distribution-scripts

40 stars 24 forks source link

Fix static executable checks #88

Closed straight-shoota closed 3 years ago

straight-shoota commented 3 years ago

Fixes static executable checks which currently fails on alpine 3.13 (see https://github.com/crystal-lang/distribution-scripts/pull/83#issue-589836036).

The reason is explained in https://github.com/crystal-lang/distribution-scripts/pull/87#issuecomment-817865398

Follow-up to #79

j8r commented 3 years ago

I'll nitpick, a good practice is to use = instead of -eq. Plus, in my opinion, it is easier to understand because closer to other languages.

straight-shoota commented 3 years ago

-eq is integer comparison, = is string comparison. There's no practical difference in this case, but -eq is formally more correct.