crystal-lang / distribution-scripts

40 stars 24 forks source link

Feature/linux 32 musl #9

Closed bcardiff closed 6 years ago

bcardiff commented 6 years ago

Automate linux 32 bits binaries as in 64 bits. Even use the same Dockerfile to keep packages layout in sync.

This procedure was already checked in circleci at https://circleci.com/gh/crystal-lang/crystal/6798#artifacts/containers/0

RX14 commented 6 years ago

Looks really good, just 2 nitpicks and a small makefile rename.

bcardiff commented 6 years ago

Nitpicks addressed

RX14 commented 6 years ago

@bcardiff what about the makefile rename?

I'd rename all the 64bits makefile targets to end in 64. Then have an all32, all64 and keep all as all targets (32 and 64 bit)

bcardiff commented 6 years ago

64 suffix added in all the places except in the environment variable used as parameter. The updated test is been tested at https://circleci.com/workflow-run/90e76c67-8ebb-4b3e-a616-0c638cf6c3e8