search

crystal-lang / distribution-scripts

40 stars 24 forks source link

Update omnibus and build with LLVM 10 on macOS #96

Closed maxfierke closed 3 years ago

maxfierke commented 3 years ago

Picking up where @bcardiff was working last August on building with LLVM 10. I think this will get us closer to being able to build for both x86_64 and arm64 for macOS, but will be working on that more separately.

Fixes #89

Need to do more testing with it, but opening a PR for feedback

bcardiff commented 3 years ago

Hi @maxfierke thanks for investing energy on this. I have a couple of questions to understand why some of these changes were needed or wanted on your side.

I think the goal should be to have a build backed by llvm 10 (any 10 version, I recall there were some issues with llvm 10.0.1 and how libxml was advertised)

maxfierke commented 3 years ago
  • I see you are setting LLVM_ENABLE_LIBXML2=OFF. Do you remember what pushed you to set that? Was the library linked somehow on the llvm 10 output? Or something later failed because of it. Again this might be related to the linked topic.

Yeah, there were some linking issues with libxml2.tbd, if I remember correctly. The linked topic looks related.

  • Bumping dependencies in general is good, but was there other motivations to bump omnibus and openssl. This triggers other updates I am not sure how to review.

Omnibus was bumped for getting it running on macOS Big Sur. Wasn't having any luck with the prior version. With that bump, I removed or bumped some of the pieces that overlap in Omnibus, specifically OpenSSL and removing the older copy of cacerts, because it's good to keep that stuff as up to date as possible.