Closed kimburgess closed 3 years ago
Have I seen these annotations (in context of Crystal) somewhere before? If so, can you show a real example with them?
Here's the test repo I was using for the above: https://github.com/kimburgess/problem-matcher-test/commit/08fa428eb6f207063ede1b10520d6070274378a9
A couple of bits of potential fragility to note:
Looks great!
I think this should have an opt-out flag. Also there are lint errors
Thanks!
Sorry for the pointless delay. Now this is released. https://github.com/crystal-lang/install-crystal/releases/tag/v1.5.0
Adds problem matcher implementations for both compiler and spec output. This allows output of these to form inline annotation when viewed either against a commit, or during the PR process within the GitHub UI.
Limitations do exist in current upstream functionality - primarily messages can only span a single line so some information is dropped, but is still available in the full logs if required.