search

crystal-lang / shards

Dependency manager for the Crystal language
Other
765 stars 102 forks source link

Doesn't seem to support versions like 1.0.0-beta1? #318

Closed Nicolab closed 4 years ago

Nicolab commented 4 years ago

Hello,

I encountered Error resolving validator (1.0.0-beta1)

I have a doubt because: we parse 0.0.1-alpha as 0.0.1.pre.alpha but don't transform 0.0.1.beta in: https://github.com/crystal-lang/shards/pull/249#pullrequestreview-190628893

ysbaddaden commented 4 years ago

This was a mere comment and was never implemented. Any segment containing a letter indicates a prerelease. So 1.0.0-beta1 is identical to 1.0.0.beta1 and is a prerelease, but 0.1.0 or 1.2.3-4 are releases. See https://github.com/crystal-lang/shards/blob/master/test/versions_test.cr#L5

Either validator doesn't have a 1.0.0-beta1 release or you're running Shards 0.8 that doesn't support prereleases, and/or have a conflict.

Nicolab commented 4 years ago

Indeed, I'm running Shards 0.8.1 Thanks for the explanations!