search

crystal-lang / shards

Dependency manager for the Crystal language
Other
765 stars 102 forks source link

Show the shard's name when running scripts #326

Closed bcardiff closed 4 years ago

bcardiff commented 4 years ago

When running $ shards install it will now append the shard name where the script is defined

For example when running it in lucky it will show the precompiled_tasks for avram and make bin from ameba are run.

... stripped ...
Installing teeplate (0.8.0)
Installing blank (0.1.0)
Installing db (0.8.0)
Installing pg (0.20.0)
Postinstall script/precompile_tasks (avram)
Postinstall make bin (ameba)
Writing shard.lock

When the command fails, only the command is displayed with no path/dependency name.

straight-shoota commented 4 years ago

Maybe a more logical ordering would be to put the dependency name before the command? Postinstall of avram: script/precompile_tasks. This would also help to keep the names aligned in case the command wraps.

When the command fails, only the command is displayed with no path/dependency name.

Isn't the shard name a significant information in case of a failure? I'd expect that to show when the command fails as well.

bcardiff commented 4 years ago

Feedback addressed @straight-shoota