search

crystal-lang / shards

Dependency manager for the Crystal language
Other
765 stars 102 forks source link

Remove unnecessary require to break loop #375

Closed straight-shoota closed 4 years ago

straight-shoota commented 4 years ago

There was a require loop resolvers/resolver > spec > config > info > lock > package > resolvers/* which would cause code like the following to fail:

require "./src/resolvers/git"
require "./src/resolvers/path"
In src/resolvers/path.cr:4:24

 4 | class PathResolver < Resolver
                          ^-------
Error: undefined constant Resolver

Lock doesn't depend on Package, so there's no need to require it there.

jhass commented 4 years ago

Mmh, CI seems to disagree? :)

straight-shoota commented 4 years ago

Yeah, it's more messed up. Now it should be good.