search

crystal-lang / shards

Dependency manager for the Crystal language
Other
763 stars 100 forks source link

Fix: reinstall when resolver changes #425

Closed waj closed 4 years ago

waj commented 4 years ago

Currently running an install after changing the resolver from path to git doesn't do anything because GitResolver fails to detect that the current install is not what's required.

Now the Package uses the .shards.info to check that the resolver and version matches to figure out if the dependency is installed.

waj commented 4 years ago

@bcardiff I plan to (re)move some code now present within the Resolver to the Package. That logic you mention only worked for git repositories. Now it also works for path sources.

jwoertink commented 4 years ago

Could this be related? https://github.com/crystal-lang/shards/issues/398

waj commented 4 years ago

@jwoertink is that still happening with v0.11.1? Anyway I don't think it's related. Let's continue the conversation on the issue.