Use git's `checkout` feature directly to write out repo files

crystal-lang / shards

Dependency manager for the Crystal language

Other

765 stars 102 forks source link

Use git's `checkout` feature directly to write out repo files #435

Closed oprypin closed 4 years ago

oprypin commented 4 years ago

to avoid relying on a shell to pipe into tar.

Caveat: git checkout also updates the index in the repository, but that shouldn't be a problem here (is there even any index in a bare repo to start with?)

This is part of work to bring 'shards' to Windows.

oprypin commented 4 years ago

What's the holdup with this particular pull request (the last one)? 😅

straight-shoota commented 4 years ago

I was waiting for CI to finish after I fixed the merge conflict. Not sure why the milestone was changed. It should be ready to merge right away. @bcardiff Anything holding this up?

bcardiff commented 4 years ago

I changed the milestone because v0.12.0 is released already, but the milestone was not closed. I created a vNext because I'm not sure the next is 0.12.1 or 0.13.0

straight-shoota commented 4 years ago

Thanks @oprypin