crystal-lang / shards

Dependency manager for the Crystal language
Other
763 stars 100 forks source link

Add --skip-postinstall cli option to install and update #475

Closed bcardiff closed 3 years ago

bcardiff commented 3 years ago

Partially implements the suggestions of https://github.com/crystal-lang/shards/issues/468#issuecomment-767064550

The postinstall instructions will be logged with a trailing (skipped).

Usually the postinstall will generate target binaries that are then linked/copied by Package#install_executables.

With this PR the target binaries will not exist and wont be linked/copied, which is fine.

To complete the idea https://github.com/crystal-lang/shards/issues/468#issuecomment-767064550 and decouple the commands for Windows environments in a comfortable way I am not sure if it's better to a) make the shards postinstall --dry-run [shard names] perform postinstall and install_executables or if b) postinstall and install-executables should be different commands.

Either way that can be handled in a separate PR. This should be enough to download dependencies with postinstall in Windows.