crystal-lang / shards

Dependency manager for the Crystal language
Other
763 stars 100 forks source link

Fix broken SOURCE_DATE_EPOCH in docs.mk #479

Closed straight-shoota closed 3 years ago

straight-shoota commented 3 years ago

The call is totally broken and doesn't actually work (would need to define the function using define). It just happend to still succeed inside a git repository.

I don't think we really need file-specific SOURCE_DATE_EPOCH, so we can spare the call entirely and just use a global variable.

This change also allows to specify SOURCE_DATE_EPOCH as an external variable when building docs.

Ref https://github.com/crystal-lang/shards/issues/253#issuecomment-785079152