search

crystal-lang / shards

Dependency manager for the Crystal language
Other
763 stars 100 forks source link

Run the main shard's `postinstall` script as well #485

Closed Blacksmoke16 closed 1 year ago

Blacksmoke16 commented 3 years ago

Resolves #484.

Blacksmoke16 commented 3 years ago

Oof, guess this needs a merge. I can do that tonight.

beta-ziliani commented 3 years ago

Hi @Blacksmoke16 we are releasing a new Shards version, and we discussed within the Core team which PRs to merge. This particular PR sparked discussions (that I will transfer to the issue), so we decided to postpone it until we solved those. Perhaps we will keep is as is, but we decided not to rush it for this release. Sorry for the late notice, and for the extra work that you put because of this.

Blacksmoke16 commented 2 years ago

@beta-ziliani Going back thru my older PRs. Did those extra discussions ever make it to this PR?

beta-ziliani commented 1 year ago

Sorry for the super long delay about this one. We discussed it with the team, and there's a general agreement that postinstall is not really recommended. Therefore, continuing to develop it is going kind of in the opposite direction of what we'd like to see happening here.

We're happy to discuss this further if you want this is a mistake.

Blacksmoke16 commented 1 year ago

@beta-ziliani Nope it's fine. I personally don't have a use for this feature at the moment; so happy to just close for now.