search

crystal-lang / shards

Dependency manager for the Crystal language
Other
763 stars 100 forks source link

Feature/warn only crystal version #496

Closed beta-ziliani closed 3 years ago

beta-ziliani commented 3 years ago

This PR changes the semantics of the crystal: field to be a "maintainers claim it works in these versions of the compiler", warning in case the current version is not listed. An empty field means *, as coded in PR #493 by @oprypin.

It is an implementation (by @bcardiff) of the proposal I made as a comment in PR #493.

straight-shoota commented 3 years ago

It seems this needs a formatter run.

beta-ziliani commented 3 years ago

I think we're good to go, once the CI passes let's merge this (pinging @straight-shoota)

luislavena commented 3 years ago

Hello @beta-ziliani @bcardiff, possible a new release of shards with this change is made?

Not asking packages of Crystal 1.0.1 to be released, but at least having shards updates so impacted folks can use or point users to that manual upgrade until a new distribution of Crystal is released.

Thank you.

oprypin commented 3 years ago

(literally speaking, it should be possible, as mentioned here)