search

crystal-lang / test-ecosystem

7 stars 6 forks source link

mint is taking forever #21

Open beta-ziliani opened 2 years ago

beta-ziliani commented 2 years ago

also crystal-db, although not sure they're related

straight-shoota commented 2 years ago

In the mint test it seems that the ameba check hangs. It seems to be caused by the internal API change in the compiler, which should be fixed by https://github.com/crystal-ameba/ameba/pull/259 Funny thing is that ameba still compiles. The compiler changes only break ameba's specs, which we also observed. But the ameba app itself builds but the binary is unusable (it seems to run an endless loop). This is because the breaking changes just affect equality checks with symbols, which do not cause a compile time error. So that's actually a good example why using symbols is bad and it's good that we've refactored that. Ameba just needs to be updated to the new API.

straight-shoota commented 2 years ago

The failing spec in crystal-db is unrelated. It's just expecting a specific error message from string to int conversion, but the format has changed in crystal-lang/crystal#11883. This needs to be fixed in crystal-db (https://github.com/crystal-lang/crystal-db/pull/163).