crystal-loot / selenium.cr

Selenium library for Crystal
https://crystal-loot.github.io/selenium.cr/
MIT License
24 stars 7 forks source link

Capabilities need to be re-worked #14

Closed matthewmcgarvey closed 3 years ago

matthewmcgarvey commented 3 years ago

For instance, you should be able to set a binary in chrome options but you can't since the type of the hash is Hash(String, Array(String))

https://github.com/matthewmcgarvey/selenium.cr/blob/5e4e0f563bf6c06e9713fb1ee50c59cbd799345b/src/selenium/chrome/capabilities.cr#L2-L3

I'm not sure having a class is the best idea. Maybe it should be a method that dynamically creates the capabilities hash.