implement `Selenium::Element#submit`

crystal-loot / selenium.cr

Selenium library for Crystal

https://crystal-loot.github.io/selenium.cr/

MIT License

24 stars 7 forks source link

implement `Selenium::Element#submit` #26

Closed mamantoha closed 1 year ago

mamantoha commented 1 year ago

Inspired from Ruby and Python implementations

mamantoha commented 1 year ago

If you are wonder about ELEMENT_KEY = "element-6066-11e4-a52e-4f735466cecf" check https://www.w3.org/TR/2015/WD-webdriver-20150827/

matthewmcgarvey commented 1 year ago

Hey @mamantoha , I'm happy with this change, you've just got the failing format check if you could fix that.

mamantoha commented 1 year ago

Hi @matthewmcgarvey . Ameba linter fails are not related to changes in this PR. This is due new version of ameba being released. You can merge and then run ./bin/ameba --fix. Or I can fix the warning here. What should I do?

matthewmcgarvey commented 1 year ago

Ahh, sorry about that. I fixed it myself, and thank you for helping out!