crystal-loot / selenium.cr

Selenium library for Crystal
https://crystal-loot.github.io/selenium.cr/
MIT License
24 stars 7 forks source link

Consider port to windows? #31

Closed zw963 closed 1 year ago

zw963 commented 1 year ago

Please check following issue too.

https://github.com/crystal-lang/crystal/issues/5430#issuecomment-1537373838

Thanks

zw963 commented 1 year ago

I add my app workflow for windows, get following error.

In lib\selenium\src\selenium\service.cr:99:20

 99 | process.signal(Signal::KILL)

                     ^-----------
Error: undefined constant Signal::KILL

this is the log.

Following is the portable advice for Signal.

https://crystal-lang.org/api/1.8.1/Signal.html#portability

jwoertink commented 1 year ago

I just got this too on https://github.com/crystal-loot/exception_page/pull/40