Memory leaks on Apple Silicon on Apple Silicon

fiwswe commented 5 years ago

Macs Fan Control (MFC) is running for days and weeks at a time on my Mac mini server. I have noticed that it tends to accumulate a lot of memory over time. Quitting MFC and restarting it will restart the cycle.

The issue has existed with older versions of MFC as well. I had hoped that issue #185 would have fixed the memory problem. But while the number of Mach ports now seems stable, the memory leak persists.

For example: After launch of MFC: com.crystalidea.macsfancontrol.smcwrite: 644 KB, the app: 38.8 MB. An hour later: com.crystalidea.macsfancontrol.smcwrite: 644 KB, the app: 50.5 MB. About 67:30 hours after launch: com.crystalidea.macsfancontrol.smcwrite: 688 KB, the app: 1,010.1 MB.

During this time the configuration window was only open at the beginning (at most an hour or so). After that the machine was running without user interaction.

FWIW: I have not enabled fan related activities in iStat Menus so hopefully there should be no conflict.

Thanks for this tool and for supporting it! Macs Fan Control 1.5.0 [Qt 5.13.1] Macmini4,1 CPU: Intel(R) Core(TM)2 Duo CPU P8800 @ 2.66GHz [2 cores] GPU: NVIDIA GeForce 320M macOS 10.12.6 Fans: Exhaust-min{1800}curr{5504}max{5500}mode{2,TC0D,37,47} TempSensors: TA0P (Ambient) - 29.875, 29.875 TC0D (CPU Diode) - 52.5, 52.5 TC0G () - 70, 70 TC0H (CPU Heatsink) - 44.875, 44.875 TC0P () - 44.1328, 44.1328 TC0p (CPU Proximity) - 44.375, 44.375 TCPG () - 73, 73 TH0G () - 60, 60 TH0P () - 29.5, 29.5 TH0p () - 29.5, 29.5 TM0G () - 75, 75 TM0P () - 45.75, 45.75 TM0p (Memory Proximity) - 45.75, 45.75 TN0D (MCP Diode) - 46.5, 46.5 TN0G () - 67, 67 TN0P () - 39.3711, 39.3711 TN0p (Northbridge Proximity) - 39.375, 39.375 TN1D () - 54, 54 TN1E () - 54, 54 TN1F () - 55.1914, 55.1914 TN1G () - 90, 90 TN1S () - 55.1914, 55.1914 TNPG () - 70, 70 TO0P () - 128, 128 TO0p () - 128, 128 TW0P (Airport Card) - 35.25, 35.25 Tm0P () - 38.625, 38.625 Tp0C (PSMI Supply AC/DC Supply 1) - 39.7031, 39.7031 Disk drives: WDC WD10JFCX-68N6GN0 - 31 Samsung SSD 850 PRO 512GB - 35 Path: /Applications/Macs Fan Control.app/Contents/MacOS/Macs Fan Control Potentially conflicted app: iStat Menus 6 /Library/Application Support/iStat Menus 6/bandwidth.db /Library/Application Support/iStat Menus 6/cities.db /Library/Application Support/iStat Menus 6/iStat Menus Status.app /Library/Application Support/iStat Menus 6/iStat Menus Uninstaller.app /Library/Application Support/iStat Menus 6/iStat Menus Updater.app /Library/Application Support/iStat Menus 6/iStatMenusAgent.app /Library/Application Support/iStat Menus 6/iStatMenusDaemon /Library/Application Support/iStat Menus 6/iStatMenusFans /Library/Application Support/iStat Menus 6/uptime.db

kleuter commented 5 years ago

Issue located and fixed, thank you. Will be available in the upcoming update (1.5.1)

fiwswe commented 5 years ago

Wow, that was fast. Thanks!

I'll let you know the results when the new version is out.

kleuter commented 5 years ago

It's not the final 1.5.1, but you'd like you can test the memory leak

fiwswe commented 5 years ago

Thanks for letting me test this!

I have rebooted the Mac mini, quit the older (1.5.0.1) app, replaced it with the 1.5.1.2 (beta) app, launched the beta and…

A few seconds after launch (after closing the main window) [2019.10.01 13:13:50]: com.crystalidea.macsfancontrol.smcwrite: 668 KB, the app: 37.5 MB. Mach ports: 27, 241 respectively.
About 59 min. later [2019.10.01 14:12:50]: com.crystalidea.macsfancontrol.smcwrite: 652 KB, the app: 53,2 MB. Mach ports: 25, 253 respectively.

During this time I watched the memory for the app slowly climb up. I did not interact with MFC at all during this time and mostly left the machine running without any interaction.

Neither the MFC settings nor anything else on the machine was (manually) modified since the original bug report.

Conclusion:

Mach ports remain stable (the slight increase during this time is probably just a fluctuation).
The memory leak still exists (unfortunately). It seems to be leaking at an average rate of about 4.54 KB/s.

Here are screen shots of Activity Monitor to illustrate the issue: [2019.10.01 13:13:50]

[2019.10.01 14:12:50]

And this is what the menu bar display is configured to be (in case that makes any difference):

kleuter commented 5 years ago

I can confirm that, found only one memory leak, seem like there's another one. Will keep searching, thank you

kleuter commented 5 years ago

Can you please try the 1.5.1 beta?

fiwswe commented 5 years ago

Ok, I have started the test. I'll let you know shortly what the results are…

fiwswe commented 5 years ago

Alright, it seems you are on the right track! The leak is getting smaller.

Setup: I am running the 1.5.1.5 (beta, Sierra) version as my Mac mini uses macOS 10.12.6. Again nothing was changed manually on the machine from previous tests except for replacing MFC.

Results: Here are the numbers (only for the app memory as all the other values seem normal):

Very shortly after launch (after closing the main window): 34.9 MB
∆T: 00:08:44: 36.8 MB (ø leaks 3.71 KB/s for a total of 1.9 MB)
∆T: 00:17:51: 38.9 MB (ø leaks 3.82 KB/s for a total of 4.0 MB)
∆T: 00:27:57: 41.0 MB (ø leaks 3.72 KB/s for a total of 6.1 MB)
∆T: 00:47:29: 45,6 MB (ø leaks 3.85 KB/s for a total of 10.7 MB)
∆T: 00:59:53: 48,4 MB (ø leaks 3.85 KB/s for a total of 13.5 MB)

For reference: The previously tested version 1.5.1.2 (beta) had leaked an average of 4.54 KB/s for a total of 15.7 MB after 59 min.. This went down to an average of 3.08 KB/s over 02:06:56:24 days for a total of 595.0 MB.

kleuter commented 5 years ago

@fiwswe thank you very much for the feedback!

fiwswe commented 5 years ago

Update: After a runtime of 02:06:07:26 days the leak grew to 274.3 MB (ø1.44 KB/s).

That is considerably less than version 1.5.1.2 (beta) which leaked 595 MB (ø3.08 KB/s) after the comparable time of 02:06:56:24 days.

kleuter commented 5 years ago

Please try the latest beta https://github.com/crystalidea/macs-fan-control/issues/218

fiwswe commented 5 years ago

Hi!

Same resting environment as before, only with the new version 1.5.1.5 beta, Sierra, you made available today:

• Very shortly after launch (after closing the main window): 36.1 MB • ∆T: 01:22:00: 47.6 MB (ø leaks 2.39 KB/s for a total of 11.5 MB)

So while not perfect yet it looks like an ≈38% improvement on the memory leak issue. I'll keep it running and report more data later…

Thanks!

BTW: Not sure if this is an issue or not, but when quitting the app (using the menu command) the helper tool keeps running. I used Activity Monitor to quit the helper tool before running the new version.

kleuter commented 5 years ago

Thank you, will keep searching.

Not sure if this is an issue or not, but when quitting the app (using the menu command) the helper tool keeps running.

It's totally normal.

fiwswe commented 5 years ago

Here is the promised update: • ∆T: 00:17:31:41: 174.9 MB (ø leaks 2.25 KB/s for a total of 138.8 MB) • ∆T: 02:11:59:46: 253.8 MB (ø leaks 1.03 KB/s for a total of 217.7 MB)

fiwswe commented 5 years ago

I have started testing version 1.5.1.6 (sierra) today. Here are the first results:

• Very shortly after launch (after closing the main window): 36.3 MB • ∆T: 17:26:07: 179.6 MB (ø leaks 2.34 KB/s for a total of 143.3 MB)

This value seems to be slightly worse than the corresponding value from version 1.5.1.5 (beta, sierra dated Nov. 5th.). Although the difference is small enough to be considered a natural fluctuation.

fiwswe commented 4 years ago

Update: • ∆T: 00:23:33:23: 235.9 MB (ø leaks 2.41 KB/s for a total of 199.6 MB) • ∆T: 05:09:45:53: 861.1 MB (ø leaks 1.81 KB/s for a total of 824.8 MB)

kleuter commented 4 years ago

Thank you for the follow up, will keep digging!

fiwswe commented 4 years ago

Final update for version 1.5.1.6 (sierra): • ∆T: 09:09:45:40: 887.0 MB (ø leaks 1.07 KB/s for a total of 850.7 MB) • ∆T: 11:14:25:08: 895.6 MB (ø leaks 0.88 KB/s for a total of 859.3 MB) • ∆T: 29:20:55:23: 2,220 MB (ø leaks 0.87 KB/s for a total of 2,183.7 MB)

So clearly the average rate of the leaks goes down over time but given very long runtimes the accumulated leaks are still significant.

I have downloaded and installed version 1.5.3.9 and started testing:

• Very shortly after launch (after closing the main window): 36.9 MB • ∆T: 00:27:28: 39.0 MB (ø leaks 1.28 KB/s for a total of 2.1 MB, lowest value for this runtime yet!) • ∆T: 01:21:20: 43.4 MB (ø leaks 1.36 KB/s for a total of 6.5 MB, lowest value for this runtime yet!) • ∆T: 02:44:21: 44.9 MB (ø leaks 0.83 KB/s for a total of 8.0 MB, lowest average value yet!)

Good work! Things seem to be improving on the memory leak front :-)

kleuter commented 4 years ago

Thanks a lot for the follow up.

grr commented 4 years ago

still leaking. version 1.5.7.20 is using 143MB and the leaks commands reports 1041271 leaks for 99961088 total leaked bytes.

zecanard commented 4 years ago

Hadn’t noticed this before. Macs Fan Control 1.5.8.21 Pro (iMac19,1).

Physical footprint:         1.1G
Physical footprint (peak):  1.1G
----

leaks Report Version: 4.0
Process 532: 14239605 nodes malloced for 1088844 KB
Process 532: 14100443 leaks for 1092767760 total leaked bytes.

runkaiz commented 4 years ago

Just wonder what language is the app coded in, I understand memory leaks in the kernel since it's written in c and assembler.

kleuter commented 4 years ago

I do need to know which settings are used. Sensor-based control? A screenshot of the app would be fine. Thanks.

zecanard commented 4 years ago

At the time I was experiencing this issue, I was switching between the following two profiles:

These days, I stick to a single one, and I also have a scheduled job that automatically restarts Macs Fan Control, so I haven’t observed it. I will disable it and report back if I experience memory leaks using a single profile.

kleuter commented 4 years ago

Please post the complete output of the leaks command (when you experience leaks). Thanks!

zecanard commented 4 years ago

Sorry it’s taken so long. I’ve rebooted my computer more frequently lately, and Macs Fan Control wasn’t leaking memory even after several days. Weirdly enough, leaks has been reporting no leaks even when the app was taking 800+ MiB of memory at times. This time, it’s only sitting on 117 MiB.

leaks.zip

kleuter commented 4 years ago

omg, thanks a lot, we found the leak! Will be fixing it asap

kleuter commented 4 years ago

Quick build with NSMutableParagraphStyle leak fixed.

zecanard commented 4 years ago

Thanks a bunch! Will keep an eye on it.

icanc0 commented 2 years ago

it seems like memory leaks are still happening

Process 66937 is not debuggable. Due to security restrictions, leaks can only show or save contents of readonly memory of restricted processes.

Process: Macs Fan Control [66937] Path: /Applications/Macs Fan Control.app/Contents/MacOS/Macs Fan Control Load Address: 0x102638000 Identifier: com.crystalidea.macsfancontrol Version: 1.5.12 (41) Code Type: ARM64 Platform: macOS Parent Process: ??? [1]

Date/Time: 2022-05-26 08:23:12.349 -0400 Launch Time: 2022-05-22 15:44:42.627 -0400 OS Version: macOS 12.3 (21E230) Report Version: 7 Analysis Tool: /usr/bin/leaks

Physical footprint: 258.0M Physical footprint (peak): 258.4M

leaks Report Version: 4.0 Process 66937: 2597863 nodes malloced for 191092 KB Process 66937: 2518877 leaks for 181375264 total leaked bytes.

the rest of the logs are too big, so here's a snippet

  1 (16 bytes) ROOT LEAK: 0x600002539470 [16]
  1 (16 bytes) ROOT LEAK: 0x600002539480 [16]
  1 (16 bytes) ROOT LEAK: 0x600002539490 [16]
  1 (16 bytes) ROOT LEAK: 0x6000025394a0 [16]
  1 (16 bytes) ROOT LEAK: 0x6000025394b0 [16]
  1 (16 bytes) ROOT LEAK: 0x6000025394c0 [16]
  1 (16 bytes) ROOT LEAK: 0x6000025394f0 [16]
  1 (16 bytes) ROOT LEAK: 0x600002539540 [16]
  1 (16 bytes) ROOT LEAK: 0x600002539550 [16]
  1 (16 bytes) ROOT LEAK: <QCocoaSegmentedButtonTarget 0x600002530a40> [16]

sometimes after a few days, it can reach around 600MB

kleuter commented 2 years ago

please upload complete logs somewhere.

fiwswe commented 2 years ago

While the leaks have decreased, thanks @kleuter, I have given up on getting them all fixed. I use this, launched once a day via user crontab:

#!/bin/bash
#
#   As a workaround for memory leaks in Macs Fan Control we restart the app on a schedule.
#

MFC_PROCESSNAME='Macs Fan Control'
#   NOTE: Modify the path if you put the app somwehre else:
MFC_APP='/Applications/Macs Fan Control.app'

/usr/bin/killall -u "$(/usr/bin/whoami)" -HUP "$MFC_PROCESSNAME"
if [ $? -eq 0 ];then
    /usr/bin/open "$MFC_APP"
fi

#
#   EOF.
#

(MFC 1.5.11 running on macOS 10.12.6 on an old 2010 Mac mini Server with a broken HD temp sensor connector, which can not be upgraded to a more modern OS.)

HTH fiwswe

Lewiscowles1986 commented 1 year ago

Just rebooted MFC 1.5.15 for just this, was using nearly 1GB RAM; restarted it's <100MB

kleuter commented 1 year ago

Please post the complete output of the leaks command in Terminal (when you experience leaks). Thanks!

Lewiscowles1986 commented 1 year ago

$ leaks 500

Process 500 is not debuggable. Due to security restrictions, leaks can only show or save contents of readonly memory of restricted processes.

Process:         Macs Fan Control [500]
Path:            /Applications/Macs Fan Control.app/Contents/MacOS/Macs Fan Control
Load Address:    0x102a10000
Identifier:      com.crystalidea.macsfancontrol
Version:         1.5.15 (55)
Code Type:       ARM64
Platform:        macOS
Parent Process:  ??? [1]

Date/Time:       2023-05-12 21:51:54.597 +0100
Launch Time:     2023-05-07 09:37:30.103 +0100
OS Version:      macOS 13.3.1 (22E261)
Report Version:  7
Analysis Tool:   /usr/bin/leaks

Physical footprint:         338.9M
Physical footprint (peak):  339.1M
Idle exit:                  untracked
----

leaks Report Version: 4.0
Process 500: 4476542 nodes malloced for 320638 KB
Process 500: 4424715 leaks for 318577936 total leaked bytes.

After terminating the process, I got a lot of output in my terminal

Additional terminal output (truncated it seems)

``` 1 (32 bytes) _event + 96 --> 0x600018951560 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189512e0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951580 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951680 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189516a0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189513e0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951340 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951300 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951640 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189515c0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189513a0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951700 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189514c0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951060 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951360 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189517c0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951620 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189514e0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951220 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951720 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951480 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189516e0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951600 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189518c0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951660 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951820 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189515e0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951760 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951780 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189516c0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951900 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951920 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951960 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951800 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189518a0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189517a0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951540 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189519e0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951a40 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189511e0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951a20 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951a80 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189519a0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x6000189519c0 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951860 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x60001894fc00 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x60001894f840 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x60001894fb60 [32] 2 (144 bytes) ROOT LEAK: [112] 1 (32 bytes) _event + 96 --> 0x600018951c20 [32] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 1 (112 bytes) ROOT LEAK: [112] 2 (80 bytes) ROOT LEAK: [48] 1 (32 bytes) clickedPtr + 24 --> 0x6000002c0200 [32] 2 (80 bytes) ROOT LEAK: [48] 1 (32 bytes) clickedPtr + 24 --> 0x6000002b4fc0 [32] 2 (80 bytes) ROOT LEAK: [48] 1 (32 bytes) clickedPtr + 24 --> 0x6000002b1c60 [32] 1 (80 bytes) ROOT LEAK: [80] 1 (80 bytes) ROOT LEAK: [80] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (64 bytes) ROOT LEAK: [64] 1 (48 bytes) ROOT LEAK: [48] 1 (48 bytes) ROOT LEAK: [48] 1 (48 bytes) ROOT LEAK: [48] 1 (48 bytes) ROOT LEAK: [48] 1 (48 bytes) ROOT LEAK: [48] 1 (48 bytes) ROOT LEAK: [48] 1 (48 bytes) ROOT LEAK: [48] 1 (48 bytes) ROOT LEAK: [48] 1 (48 bytes) ROOT LEAK: [48] 1 (48 bytes) ROOT LEAK: [48] 1 (48 bytes) ROOT LEAK:

Lewiscowles1986 commented 1 year ago

After closing and restarting, I now have this

Obviously PID is now different.

It's likely that the RAM will stay the same for a fair while (I can check-in in the morning)

Lewiscowles1986 commented 1 year ago

Okay so it's more than doubled in 9 hours

Also trace (truncated again, as it's 80M and crashed my browser trying to add inline)

trace 88901 > log

``` Process: Macs Fan Control [88901] Path: /Applications/Macs Fan Control.app/Contents/MacOS/Macs Fan Control Load Address: 0x1008ec000 Identifier: com.crystalidea.macsfancontrol Version: 1.5.15 (55) Code Type: ARM64 Platform: macOS Parent Process: ??? [1] Date/Time: 2023-05-13 06:59:29.404 +0100 Launch Time: 2023-05-12 21:53:52.005 +0100 OS Version: macOS 13.3.1 (22E261) Report Version: 7 Analysis Tool: /usr/bin/leaks Physical footprint: 152.9M Physical footprint (peak): 153.0M Idle exit: untracked ---- leaks Report Version: 4.0 Process 88901: 1171912 nodes malloced for 87380 KB Process 88901: 1121709 leaks for 80756816 total leaked bytes. 1121709 (77.0M) << TOTAL >> ```

Lewiscowles1986 commented 1 year ago

leaks-2022-05-13-0659.log.zip

Lewiscowles1986 commented 1 year ago

Open Files and Ports

``` / /Applications/Macs Fan Control.app/Contents/MacOS/Macs Fan Control /Applications/Macs Fan Control.app/Contents/Frameworks/QtMacExtras.framework/Versions/5/QtMacExtras /Applications/Macs Fan Control.app/Contents/Frameworks/QtGui.framework/Versions/5/QtGui /Library/Preferences/Logging/.plist-cache.oM9kr99b /System/Library/CoreServices/SystemVersion.bundle/en_GB.lproj/SystemVersion.strings /Applications/Macs Fan Control.app/Contents/PlugIns/platforms/libqcocoa.dylib /Applications/Macs Fan Control.app/Contents/Frameworks/QtNetwork.framework/Versions/5/QtNetwork /System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/SystemAppearance.car /System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/FauxVibrantDark.car /Applications/Macs Fan Control.app/Contents/Frameworks/QtPrintSupport.framework/Versions/5/QtPrintSupport /Applications/Macs Fan Control.app/Contents/Frameworks/QtWidgets.framework/Versions/5/QtWidgets /Applications/Macs Fan Control.app/Contents/Frameworks/QtDBus.framework/Versions/5/QtDBus /System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/Aqua.car /System/Library/Keyboard Layouts/AppleKeyboardLayouts.bundle/Contents/Resources/AppleKeyboardLayouts-L.dat /System/Library/Caches/com.apple.IntlDataCache.le.kbdx /private/var/db/timezone/tz/2023c.1.0/icutz/icutz44l.dat /private/var/db/mds/messages/501/se_SecurityMessages /Applications/Macs Fan Control.app/Contents/PlugIns/styles/libqmacstyle.dylib /usr/lib/libobjc-trampolines.dylib /System/Library/Frameworks/AppKit.framework/Versions/C/Resources/Common.loctable /Applications/Macs Fan Control.app/Contents/Frameworks/QtCore.framework/Versions/5/QtCore /usr/share/icu/icudt70l.dat /System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/DarkAqua.car /System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/VibrantDark.car /System/Library/Extensions/NVMeSMARTLib.plugin/Contents/MacOS/NVMeSMARTLib /System/Library/Frameworks/AppKit.framework/Versions/C/Resources/InputManager.loctable /System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/Assets.car /System/Library/Fonts/SFNS.ttf /System/Library/Fonts/Menlo.ttc /System/Library/Frameworks/AppKit.framework/Versions/C/Resources/MenuCommands.loctable /System/Library/Fonts/Helvetica.ttc /System/Library/PrivateFrameworks/SFSymbols.framework/Versions/A/Resources/CoreGlyphs.bundle/Contents/Resources/Assets.car /System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/FauxVibrantLight.car /System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/VibrantLight.car /System/Library/Keyboard Layouts/AppleKeyboardLayouts.bundle/Contents/Resources/InfoPlist.loctable /Library/Caches/com.apple.iconservices.store/415736E8-7021-3378-AE56-A1F600708C5E.isdata /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Resources/Extras2.rsrc /private/var/folders/7b/npjgl0711f154yjpn8g0f85m0000gn/C/com.apple.iconservices/store.index /private/var/db/analyticsd/events.allowlist /dev/null /dev/null /dev/null /dev/urandom ->0xb1ec723cdbffdd7c ->0x776f5ed73414abf4 /private/var/folders/7b/npjgl0711f154yjpn8g0f85m0000gn/T/MACSFANCONTROL ->0xc94e7a8745425c8f ->0xc94e7a874542500f /private/var/folders/7b/npjgl0711f154yjpn8g0f85m0000gn/T/MacsFanControl.log ->0x9b0c1540122463d ->0x61dded2aae0484ca [ctl com.apple.netsrc id 8 unit 19] ->0xc94e7a8745429407 ```

kleuter commented 1 year ago

Issue located and fixed, thanks a lot, v1.5.16 beta will be published soon

Lewiscowles1986 commented 1 year ago

How cool. Thanks!

kleuter commented 1 year ago

https://github.com/crystalidea/macs-fan-control/issues/693

Lewiscowles1986 commented 1 year ago

Beta is holding steady at 77MB RAM 👍

kleuter commented 1 year ago

Perfect! Will try making making memory footprint even smaller.

Lewiscowles1986 commented 1 year ago

Honestly @kleuter I think <100mb is fine, live free 😂

crystalidea / macs-fan-control

Memory leaks on Apple Silicon on Apple Silicon #214

Physical footprint: 258.0M Physical footprint (peak): 258.4M