crystian / ComfyUI-Crystools

A powerful set of tools for ComfyUI
MIT License
546 stars 26 forks source link

AMD GPU Monitoring #47

Closed PurplefinNeptuna closed 3 days ago

PurplefinNeptuna commented 3 months ago

Adds basic AMD GPU monitoring.

Screenshot_20240415_102714

tested with RX 6700XT on Linux (ROCm 6.0.2).

working well also with nvidia gpu (library usage is skipped).

PurplefinNeptuna commented 3 months ago

image Not working for Windows so it's linux only

PurplefinNeptuna commented 3 months ago

image Added support for amdsmi which usually already installed in system-wide python for AMD Linux users, it has temperature readings. no pypi wheel for it, so i'm not put it to requirements.txt and only add it as an optional imports Although amdsmi project file is available locally in /opt/rocm/share/amd_smi/ for AMD Linux users.

crystian commented 3 months ago

I'll check in these days, thanks @PurplefinNeptuna

crystian commented 2 months ago

Sorry @PurplefinNeptuna this weekend I'm going to merge/review

PurplefinNeptuna commented 2 weeks ago

huh? gpu.py whitespace changed so much

PurplefinNeptuna commented 2 weeks ago

@crystian what will happened with gpu monitoring when comfyui use the new menu?

crystian commented 2 weeks ago

@PurplefinNeptuna right! by other PR, I'll change it by the other menu, I'm not sure right now, I will wait to more stable version