search

crystian / ComfyUI-Crystools

A powerful set of tools for ComfyUI
MIT License
697 stars 33 forks source link

AMD [NOT MERGE!] #77

Closed crystian closed 2 months ago

crystian commented 2 months ago

Just for comparative branches, I am never going to merge it. It breaks installation on Windows with this error:

image

If you are a Linux user with AMD card, you can use this branch rather than the main

Powered by: @PurplefinNeptuna

PurplefinNeptuna commented 2 months ago

@crystian ah, I forgot to test this on windows, my bad. can you try install pyrsmi and running it on your windows?

from pyrsmi import rocml
rocml.smi_initialize()

if an error raised, at least we can just use that library with try catch and have amd on linux supported without breaking windows install

PurplefinNeptuna commented 2 months ago

pyrsmi seems ok in windows (tested both amd and nvidia gpu), it throws error but we can catch it

crystian commented 2 months ago

@PurplefinNeptuna can you make a PR with the changes on branch AMD? (on your fork) but if it needs to install pyamdgpuinfo, it will break on installation not in execution (where we can catch it)

PurplefinNeptuna commented 2 months ago

@crystian pyamdgpuinfo isn't needed, I was changed to it before because temperature reading (pyrsmi dont have it) and forgot to test it on windows

crystian commented 2 months ago

but I see this library in the PR, please update it and I'll check it

PurplefinNeptuna commented 2 months ago

@crystian done, please check it