search

crystian / ComfyUI-Crystools

A powerful set of tools for ComfyUI
MIT License
697 stars 33 forks source link

bad idea to use "pyamdgpuinfo" total for all enviroment. #79

Closed wikeeyang closed 1 month ago

wikeeyang commented 1 month ago

Describe the bug
ComfyUI can't load ComfyUI-Crystools node.

To Reproduce
in windows and Nvidia GPU, but "pyamdgpuinfo" Only Linux is supported, using the AMD GPU driver.

Expected behavior
File "C:\ComfyUI_Mie_V20\ComfyUI\custom_nodes\ComfyUI-Crystools__init__.py", line 24, in from .server import File "C:\ComfyUI_Mie_V20\ComfyUI\custom_nodes\ComfyUI-Crystools\server__init__.py", line 1, in from .monitor import File "C:\ComfyUI_Mie_V20\ComfyUI\custom_nodes\ComfyUI-Crystools\server\monitor.py", line 4, in from ..general import cmonitor File "C:\ComfyUI_Mie_V20\ComfyUI\custom_nodes\ComfyUI-Crystools\general__init__.py", line 1, in from .monitor import * File "C:\ComfyUI_Mie_V20\ComfyUI\custom_nodes\ComfyUI-Crystools\general\monitor.py", line 5, in from .hardware import CHardwareInfo File "C:\ComfyUI_Mie_V20\ComfyUI\custom_nodes\ComfyUI-Crystools\general\hardware.py", line 4, in from .gpu import CGPUInfo File "C:\ComfyUI_Mie_V20\ComfyUI\custom_nodes\ComfyUI-Crystools\general\gpu.py", line 3, in import pyamdgpuinfo ModuleNotFoundError: No module named 'pyamdgpuinfo'

[2024-07-18 10:15] Cannot import C:\ComfyUI_Mie_V20\ComfyUI\custom_nodes\ComfyUI-Crystools module for custom nodes: No module named 'pyamdgpuinfo'

Screenshots
[2024-07-18 10:15] 0.1 seconds (IMPORT FAILED): C:\ComfyUI_Mie_V20\ComfyUI\custom_nodes\ComfyUI-Crystools

Error in console:
[2024-07-18 10:15] 0.1 seconds (IMPORT FAILED): C:\ComfyUI_Mie_V20\ComfyUI\custom_nodes\ComfyUI-Crystools

Versions:
Copy the output of the console (4 parts), like this: Windows 11 x64 Python version: 3.10.11 Total VRAM 24474 MB, total RAM 65318 MB pytorch version: 2.3.0+cu121 xformers version: 0.0.26.post1 Crystools version: 1.14.0

Loading: ComfyUI-Manager (V1.25.3)

ComfyUI-Manager (V2.46.3)

Additional context
I think this will occuar error for all Nvidia GPU and Windows platform user.

wikeeyang commented 1 month ago

I hope during project installation, different dependencies are automatically used, for windows and nvidia gpu env don't install this package...

PurplefinNeptuna commented 1 month ago

why you are using amd branch?

wikeeyang commented 1 month ago

I don't know, just git pull to upgrade ComfyUI-Crystools plugin.

crystian commented 1 month ago

umm, you are using the branch AMD ¯_(ツ)_/¯