search

crystian / ComfyUI-Crystools

A powerful set of tools for ComfyUI
MIT License
697 stars 33 forks source link

WIP AMD Support #98

Open crystian opened 1 month ago

crystian commented 1 month ago

@PurplefinNeptuna I need to remove the support because the manager does not support the format of requirement with:

--extra-index-url https://test.pypi.org/simple
PurplefinNeptuna commented 1 month ago

hmm, probably for security reason. because non manager user can just use that requirement.txt

@crystian most likely solution is by checking the package manually by:

from importlib.util import find_spec
if find_spec('pyrsmi') is not None:
    from pyrsmi import rocml

and tell AMD GPU user to install pyrsmi themself :rofl:

PurplefinNeptuna commented 1 month ago

@crystian good news, I asked ltdrdata at https://github.com/ltdrdata/ComfyUI-Manager/discussions/918, and they said now we can add index url for python packages in newest version of comfyui-manager

crystian commented 1 month ago

oh nice! thanks @PurplefinNeptuna !

PurplefinNeptuna commented 1 month ago

@crystian currently I'm not using my PC for a while, so you might can fix this by changing requirement.txt to:

pyrsmi==0.0.6 --index-url https://test.pypi.org/simple

comfyui-manager read and install packages per line in requirement.txt (that's why it was causing error before), so it would not change the other packages' index url