search

crysxd / OctoApp-Plugin

Companion plugin for OctoApp
GNU Affero General Public License v3.0
52 stars 4 forks source link

Update install.sh #54

Closed pchulpjoost closed 4 months ago

pchulpjoost commented 4 months ago

Removed the base64 ascci art so it can be run on the SonicPad

crysxd commented 4 months ago

Thanks for the PR! I think it's better to make the ASCII art optional by appending | true so if base64 fails the script continues. I like my ASCII art :)

Did you encounter any other issues with the Sonic Pad besides this? I don't have one myself unfortunately.

pchulpjoost commented 4 months ago

Hi Christian,

Tanks for your reply. The script did run after I removed your beautiful art. Unfortunately, the Octo Everywhere App still says that the companion plug-in isn’t installed. I haven’t had the time to look into it further.

If you find it interesting to play with the SonicPad, I can give you remote access to it and you can see for yourself.

Kind regards, Met vriendelijke groet,

crysxd commented 4 months ago

That would be awesome! Some time ago somebody also mentioned that there are problems with the installation because of a specific python package I use, but that doesn't seem to be the problem for you.

Could you start by sending me a bug report from the app? You can do so at main menu > Settings > FAQ & Help > Report a bug. This most likely will already tell me what the problem is with the notifications :)

pchulpjoost commented 4 months ago

Hi Christian,

here you go!

Feedback OctoApp for iPadOS 2.0.25

crysxd commented 4 months ago

Please send it to the prefilled email address hello@octoapp.eu! GitHub didn't pick up the attachment and I also wouldn't recommend posting the debug bundle publicly.

crysxd commented 4 months ago

Errors in base64 are now ignored, on Sonic Pad it will just ignore the command and move on :) I'm waiting for your bug report! :)

pchulpjoost commented 4 months ago

Great! I've send the e-mail.

Met vriendelijke groeten,

Joost Blankestijn 0612326034 blankestijnict.nl

Van: Christian Würthner @.> Verzonden: zondag 18 februari 2024 07:21 Aan: crysxd/OctoApp-Plugin @.> CC: pchulpjoost @.>; Author @.> Onderwerp: Re: [crysxd/OctoApp-Plugin] Update install.sh (PR #54)

Errors in base64 are now ignored, on Sonic Pad it will just ignore the command and move on :) I'm waiting for your bug report! :)

— Reply to this email directly, view it on GitHubhttps://github.com/crysxd/OctoApp-Plugin/pull/54#issuecomment-1950976565, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACIQANUPFPNR6L6QOUNWRG3YUGMWLAVCNFSM6AAAAABDIZUVGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQHE3TMNJWGU. You are receiving this because you authored the thread.Message ID: @.***>