search

crysxd / OctoApp-Plugin

Companion plugin for OctoApp
GNU Affero General Public License v3.0
52 stars 4 forks source link

Plugin adds non-valid gcode commands to file on upload, change to M117 LCD message command #83

Closed Triodes closed 3 days ago

Triodes commented 3 days ago

Since the latest update it seems that the plugin adds several commands to the uploaded GCODE files with the preprocessor hook.

Commands I have found are:

OCTOAPP_DISABLE_LAYER_MAGIC
OCTOAPP_LAYER_CHANGE LAYER=<n>

These are not valid GCODE commands and it seems they cause other preprocessing plugins to fail. One of them is the PrintTimeGenius plugin which completely screws up its estimates because of these commands. This PR uses the M117 Command with a message that starts with the original command. I.e.:

M117 OCTOAPP_DISABLE_LAYER_MAGIC
M117 OCTOAPP_LAYER_CHANGE LAYER=<n>

From what I could tell this should not impact the functionality of the plugin.

Lemme know if you agree!

Kind regards, Aron (Triodes)

Triodes commented 3 days ago

I just tested it locally and it does not fix the issue with the other plugin (PrintTimeGenius). But it might still be a good idea to use an existing valid GCODE command instead.

crysxd commented 3 days ago

Oh boy :D My idea was that these commands are filtered out and don't reach the printer.... So the M117 still doesn't solve the issue with the PTG plugin? How come? It should be able to process a M117, right?

I can rewrite it to use M118 (serial print), needs a bit more than your change, but if PTG can't handle that I'm not sure what to do

crysxd commented 3 days ago

Closing in favor of #84