search

crytic / building-secure-contracts

Guidelines and training material to write secure smart contracts
https://secure-contracts.com/
GNU Affero General Public License v3.0
2.18k stars 341 forks source link

refactor: remove `public` visibility from `constructor`s + add thousand separators to thousand numbers #316

Closed CJ42 closed 1 year ago

CJ42 commented 1 year ago

What does this PR introduce?

Since Solidity v0.7.0, the visibility for constructor is ignored. Remove the public visibility from all the constructors in the exercices.

https://docs.soliditylang.org/en/v0.8.19/070-breaking-changes.html#functions-and-events]]

image

Also added thousand separator as _ to increase code readability of number literals: fron 10000 to --> 10_000.

montyly commented 1 year ago

This is great, thanks @CJ42