search

crytic / echidna

Ethereum smart contract fuzzer
https://secure-contracts.com/program-analysis/echidna/index.html
GNU Affero General Public License v3.0
2.75k stars 368 forks source link

[Bug-Candidate]: Minor log message tweak #1225

Open rappie opened 7 months ago

rappie commented 7 months ago

Describe the issue:

[2024-03-25 13:03:50.70] Running slither on ....

I believe this should be either "Running slither on X ...." (not sure what X would be), or just "Running slither ...."

Code example to reproduce the issue:

N/A

Version:

2.2.3

Relevant log output:

No response

elopez commented 7 months ago

Hi @rappie! The message is Running slither on ${TARGET}....

https://github.com/crytic/echidna/blob/3f82caf9d6d8ae2eb6ba39f303a80a5d25510a40/lib/Echidna/SourceAnalysis/Slither.hs#L116

The same applies for the Compiling ${TARGET}... message

https://github.com/crytic/echidna/blob/3f82caf9d6d8ae2eb6ba39f303a80a5d25510a40/lib/Echidna/Solidity.hs#L89

Are you using . as target (i.e. echidna .)? I guess that can make it a bit confusing 😅 Maybe we should add some quotes around the path. so it doesn't get confused with the ... that indicate it's being worked on.

rappie commented 7 months ago

Ahh haha now it makes sense. :laughing: I already didn't understand why there were 4 dots instead of 3 like in most cases.

I am indeed using .

Quotes would indeed help. Also maybe a space between {TARGET} and ...