crytic / ethersplay

EVM dissassembler
GNU Affero General Public License v3.0
834 stars 116 forks source link

Move utils into the actual plugin directory #26

Closed joshwatson closed 6 years ago

joshwatson commented 6 years ago

printSourceCode.py makes the assumption that the user has symlinked ethersplay in the Binary Ninja plugin directory, then does the following:

path_to_line_number = os.path.join(os.path.dirname(os.path.realpath(__file__)),
                                   os.sep.join(["..", "utils"]))
sys.path.append(path_to_line_number)

from solidityLineNumber import SolidityLineNumber

Symlinking correctly on Windows is not completely intuitive, so this is likely not done on that platform, which then breaks this plugin. All files needed for plugin functionality should be moved into the directory that is placed in the plugins directory so that it will always work as expected.

joshwatson commented 6 years ago

Fixed in master