Update knwon_hashes.py - Githubissues

crytic / ethersplay

EVM dissassembler

GNU Affero General Public License v3.0

834 stars 116 forks source link

Update knwon_hashes.py #46

Open kirtixs opened 5 years ago

kirtixs commented 5 years ago

This pr updates hashed method names.

The hashes have been downloaded from https://www.4byte.directory/ and can be used in combination with any license as per their tos. A new util script has been added that automatically downloads the hashes from the site and saves them in a specified location.

Hashes that were present in known_hashes.py and not in 4byte.directiory have been submitted. As a positive side effect duplicate or bad methods have been removed from the list.

CLAassistant commented 5 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

redshark1802 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

joshwatson commented 5 years ago

Thanks for the contribution! We're actually in the middle of a refactor of ethersplay, and knownHashes is moving to a different module, but we'll probably add the new methods from this into that module!

kirtixs commented 5 years ago

Thanks for letting me know. In the meantime, could you accept this pr until refactoring has finished. It would probably help a few users.