crytic / ethersplay

EVM dissassembler
GNU Affero General Public License v3.0
838 stars 116 forks source link

add to the plugin manager? #57

Closed psifertex closed 1 year ago

psifertex commented 2 years ago

If ya'll are interested, it wouldn't take much to add ethersplay to the plugin manager which would be nice for discoverability. In short, update the plugin.json, and create the appropriately versioned release.

(You might find https://github.com/vector35/release_helper helpful, as incrementing the version number in the plugin and creating the tag/release can be mildly tedious otherwise).

Other than that, just let me know when the changes are done and I'll add it to the plugin manager. We'll automatically keep it updated to track the releases, no future notification necessary.

ekilmer commented 1 year ago

Hey @psifertex I took a stab at updating the plugin.json in #58. However, I'm getting some unimplemented instruction (LLIL) warnings/errors on the example test.evm file (testing with Binja 3233).

I don't know when I'll get time to look into this, but it would be nice to have those warnings fixed before making a release.

psifertex commented 1 year ago

That's a several stable versions old version of BN -- the latest stable doesn't have those:

Screenshot 2022-11-02 at 4 35 14 PM

Unless you mean the tags on the left gutter? Those are legitimate issues where the architecture plugin doesn't lift instructions and it's important to highlight them so the user knows what is and isn't implemented. Those aren't controllable by a plugin as far as I know but users can easily disable them if they don't want to see them by unchecking them in the "tag types" tab section of the "tags" left pane.

ekilmer commented 1 year ago

Just tested again on the latest stable release, and indeed, the errors have disappeared. I'll update the minimum binary ninja version to current stable.

Unless you mean the tags on the left gutter? Those are legitimate issues where the architecture plugin doesn't lift instructions and it's important to highlight them so the user knows what is and isn't implemented. Those aren't controllable by a plugin as far as I know but users can easily disable them if they don't want to see them by unchecking them in the "tag types" tab section of the "tags" left pane.

Ah! Thank you for the explanation.

ekilmer commented 1 year ago

@psifertex I tagged a release! https://github.com/crytic/ethersplay/releases/tag/v0.1.0

Please add it to the plugin manager 😄. Thank you for the help!

psifertex commented 1 year ago

Great! Added! From now on, any time you trigger a new release we should see it and will update the version in the plugin manager without any other interaction from ya'll. :-)