search

crytic / medusa

Parallelized, coverage-guided, mutational Solidity smart contract fuzzing, powered by go-ethereum
https://www.trailofbits.com/
GNU Affero General Public License v3.0
273 stars 33 forks source link

WorkerResetLimit is too small #319

Closed ggrieco-tob closed 3 months ago

ggrieco-tob commented 3 months ago

WorkerResetLimit is low, it should be 100 or more (e.g. 150). https://github.com/crytic/medusa/blob/72e9b8586ad93b37ff9063ccf3f5b471f934c264/fuzzing/config/config_defaults.go#L37

Xenomega commented 3 months ago

How did you determine this is too low or that it should be 100? Is there some bug or inadvertent effect this introduced? It's not clear why this is an issue. The performance benefit tends to be minimal, often not even 0.1%, while it balloons memory consumption. Unless you have extremely computationally complex contract deployments (I haven't seen anything make a notable performance difference yet though). If you could provide an example or more context, that would help.

Note: Your memory consumption will be directly related to workerCount workerResetLimit callSequenceLength.

ggrieco-tob commented 3 months ago

Sorry, this was my confusion. I confused this parameter with callSequenceLength. Closing this one.