search

crytic / optik

Optik is a set of symbolic execution tools that assist smart-contract fuzzers
https://github.com/crytic/optik
Other
89 stars 12 forks source link

Add contributing guideline and black to the CI #62

Closed montyly closed 2 years ago

montyly commented 2 years ago

black is run using the github super linter, and use 22.3.0. This is the same setup that for our other python tools

The contributing guideline mentions multiple linters, which are not yet there, but will be added in other PRs.

I also use the same guidelines regarding dev / master, and the issues labels that for our other tools - feel free to edit if they don't work here.

Boyan-MILANOV commented 2 years ago

We should remove the CI/Lint job before merging this since the added black workflow does the same

montyly commented 2 years ago

Good catch, I didn't notice the black part there, I will update the PR.

Btw, I noticed the CI is using python 3.8, but the project uses 3.7 overall: https://github.com/crytic/optik/blob/9a3f6ed66b45e71b47f4248611df13d192bc5377/.github/workflows/ci.yml#L18

Should we move the project to 3.8 entirely?

Boyan-MILANOV commented 2 years ago

Yeah we can just bump the whole project to 3.8, I don't see any reason not to.