crytic / slither-action

GNU Affero General Public License v3.0
128 stars 20 forks source link

Add stdout output #13

Closed tlvince closed 1 year ago

tlvince commented 2 years ago

Unfortunately GitHub Advanced Security (for the SARIF feature) is unavailable for private repos on GitHub.com. As an alternative, Slither's markdown report can be used.

This sets outputs.stdout (which is required to be a single-line string) and adds example usage to the readme. See https://github.com/tlvince/hardhat-project/pull/1#issuecomment-1147434360 to see how it looks.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

stephenctw commented 2 years ago

Nice work! I faced the same issue that Github Advanced Security is not available for private repos. The way I worked around it is to add another step to parse the SARIF report into github annotation. https://github.com/marketplace/actions/process-sarif-file

abcfy2 commented 1 year ago

Really need this feature, we need to use the markdown report. Please merge this PR. Thanks.

elopez commented 1 year ago

Thanks for the PR @tlvince! I've merged dev to update the branch, updated the README to match, and modified the escaping code to use the new multiline strings feature on Actions output. I think we can merge this now, unless you have any objections to the changes I did.

tlvince commented 1 year ago

lgtm 👍🏻