search

crytic / slither-action

GNU Affero General Public License v3.0
127 stars 19 forks source link

Mark git repositories as safe inside the slither-action container #50

Closed elopez closed 1 year ago

elopez commented 1 year ago

See https://github.com/actions/runner/issues/2033

Fixes: #49

CodeSandwich commented 1 year ago

Yes, it's working :tada: The successful CI run: https://github.com/radicle-dev/drips-contracts/actions/runs/4136557972/jobs/7150586465

CodeSandwich commented 1 year ago

This seems to be a fairly important fix, I don't know what was changed in GH runners, but it probably broke more than just my CI. Are you planning to make a release of a new version so the fix is more accessible?

FestusMaria commented 1 year ago

Confirm that it's working on my CI too, but Github status does not work as expected. It always marked job status as passing even finding is detected. Not sure if this is a separated issue.

elopez commented 1 year ago

@almost-llamas that appears to be a separate issue introduced with #13; I merged a fix in #51 today. Let me know if you still experience that when using the dev branch.

@CodeSandwich I'll try and prepare a new release early next week 👍

FestusMaria commented 1 year ago

@almost-llamas that appears to be a separate issue introduced with #13; I merged a fix in #51 today. Let me know if you still experience that when using the dev branch.

@CodeSandwich I'll try and prepare a new release early next week 👍

Thanks! It works flawlessly. 🎉