search

crytic / slither-action

GNU Affero General Public License v3.0
127 stars 19 forks source link

fix: Use --immutable option for yarn install #58

Closed dgusakov closed 10 months ago

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

dgusakov commented 11 months ago

@elopez pls review

elopez commented 11 months ago

Hi @dgusakov ! Thanks for the PR and sorry for the delay. Could you elaborate on why we should make this change?

As far as I can tell this would break dependency installation for most yarn-using projects, as immutable is not a documented option in yarn 1.x: https://classic.yarnpkg.com/en/docs/cli/install#yarn-install---frozen-lockfile-

Yarn 2.x has the option, but it also has frozen-lockfile aliased to it, so it should work nonetheless: https://yarnpkg.com/cli/install#details