search

crytic / slither-action

GNU Affero General Public License v3.0
127 stars 19 forks source link

without --ignore-compile #80

Open xxeonge opened 5 months ago

xxeonge commented 5 months ago

Hello. i need some help about solving the errors.

The error message "Failed to generate IR for L2UsdcBridge.onlyEOA." seems to occur during the import process of libraries/Address.sol in the modifier onlyEOA() function at line 97 of L2UsdcBridge.sol. How should I resolve this error?

Here are the links that I'm having this issue:

USDC/libraries/Address.sol: https://github.com/tokamak-network/tokamak-titan-canyon/blob/OR-1397-titan-canyon-unify-USDC.e-USDC-bridge-into-tokamak-contracts-bedrock-src-L2-tokamak/packages/tokamak/contracts-bedrock/src/L2-tokamak/USDC/libraries/Address.sol

USDC/usdc-bridge-contracts/L2UsdcBridge.sol: https://github.com/tokamak-network/tokamak-titan-canyon/blob/OR-1397-titan-canyon-unify-USDC.e-USDC-bridge-into-tokamak-contracts-bedrock-src-L2-tokamak/packages/tokamak/contracts-bedrock/src/L2-tokamak/USDC/usdc-bridge-contracts/L2UsdcBridge.sol

run it without --ignore-compile, it will not occurs error. What effect does this flag have on Slither?

elopez commented 5 months ago

Hi! --ignore-compile only makes it not run the build command (i.e. the extra commands that slither says it's running at the beginning when you run it without --ignore-compile, e.g. forge build --build-info ....). If your build process is the same in both cases, and you're doing a clean build on both cases, it should not make a difference whether slither invoked the build commands or you ran it manually and used ignore-compile.

Can you share an example PR where this is failing, and local logs of a successful run to compare?

SWU-SYL commented 5 months ago

Despite everything working perfectly as expected without the --ignore-compile option, but its necessity arises due to the complexity of the repository being built.