crytic / slither-action

GNU Affero General Public License v3.0

128 stars 20 forks source link

Versions after 0.3.2 take extremely long #87

Open WardenJakx opened 6 months ago

WardenJakx commented 6 months ago

What

before 0.3.2 slither would take ~5m to run
In the PR updating from slither 0.3.1 to 0.3.2 slither went from 5m to 2 hours (no other changes were made in the repo)
Even after updating to 0.4.0 the time is still 2h
Seems like something hangs after slither goes through the repo. It just stays in this completed hang state for a while before finishing (maybe related to https://github.com/crytic/slither-action/pull/76)

0.3.2

0.3.1

elopez commented 6 months ago

Hi! Thanks for the report, do you have a repo you can share to take a look at the issue? If you roll back to version 0.3.1 of the action, does it still take 5min nowadays? I'm thinking it could be an issue on slither itself, as slither v0.10.2 got released around the same time as v0.3.2 of the action.

WardenJakx commented 5 months ago

Hi, 0.3.1 still yields the same result now. Is there a way to pin the slither version used in action?

elopez commented 5 months ago

Hi @WardenJakx ! yes, you can use the slither-version option in the action: https://github.com/crytic/slither-action?tab=readme-ov-file#using-a-different-slither-version

You can report the performance regression in the Slither repository: https://github.com/crytic/slither/issues/new/choose If you can provide a link to the codebase that triggers the problem that might ease identifying the cause of the regression.

WardenJakx commented 5 months ago

unfortunately the codebase is closed source so i cannot provide additional context :(

however, after pinning the slither version to v0.10.1 everything went back to normal!

I was even able to update to slither-action 0.4.0 with no issues