search

crytic / solc-select

Manage and switch between Solidity compiler versions
GNU Affero General Public License v3.0
746 stars 99 forks source link

`install artifacts` never returns false #143

Open 0xalpharush opened 1 year ago

0xalpharush commented 1 year ago

https://github.com/crytic/solc-select/blob/7b493c684aece2dc3e4f233fe044f23c1606be95/solc_select/solc_select.py#L72

azpwnz commented 1 year ago

Hi @0xalpharush , I would love to contribute to the repo.

Could you suggest in which cases install_artifacts should return False? Would appreciate any details.

Thank you! :)

0xalpharush commented 1 year ago

@azpwnz It should return False when installation of versions are unsuccessful. That is, when get_available_versions does not contain all of the versions.

azpwnz commented 1 year ago

@0xalpharush thank you for the explanation! I've prepared a PR with the changes https://github.com/crytic/solc-select/pull/151