crytic / solc-select

Manage and switch between Solidity compiler versions
GNU Affero General Public License v3.0
758 stars 103 forks source link

[documentation]: location of binaries not as described #169

Closed NiloCK closed 1 year ago

NiloCK commented 1 year ago

Describe the issue:

From the readme:

The downloaded binaries are stored in ~/.solc-select/artifacts/.

From my console (Ubuntu) after the quick-start pip3 install solc-select:

image

Code example to reproduce the issue:

(not a code issue)

Version:

This doesn't seem to work. The version is current - just ran quick start.

image

image

Relevant log output:

No response

elopez commented 1 year ago

Hi! just to clarify, solc-select itself (i.e. the solc and solc-select executables) is installed wherever pip installs Python programs in your system. The solc binaries downloaded by solc-select (i.e. the ones you get when you run solc-select install 0.8.10 for example) are stored in ~/.solc-select/artifacts/

NiloCK commented 1 year ago

Excellent, thanks. I was hitting issues related to prior solc installations, so I starting looking for "what was where" and found something that didn't jar with my first reading of the readme.

I understand the readme's comment now :)

Feel free to close, or maybe something like

The versioned solc binaries are stored in ~/.solc-select/artifacts/.

could be a little clearer about what's stored in there.

0xicingdeath commented 1 year ago

Edited in most recent PR – thanks @NiloCK (and @elopez) :)