search

crytic / solc-select

Manage and switch between Solidity compiler versions
GNU Affero General Public License v3.0
758 stars 103 forks source link

Added additional error handling on being unable to access github #80

Open 0xicingdeath opened 3 years ago

0xicingdeath commented 3 years ago

Scenarios:

  1. If GitHub is unreachable, the earliest_release should be 0.4.10 instead of 0.4.0.
  2. If soliditylang is unreachable, an error should be raised
  3. If a user installs all, then all binaries from soliditylang will be installed, with a warning message that 0.4.0-0.4.9 are unavailable
  4. If a user tries to fetch available versions and GitHub is unreachable, solc-select will continue execution, with a warning message that 0.4.0-0.4.9 are unavailable

Setting this to a draft PR, so we have time to think about how to test.

antonper commented 2 years ago

In current version also valid_version always tries to query latestRelease. It would be nice if in case github is not accessible the latest version check will not fail.

CLAassistant commented 5 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Natalie Chin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.