Closed montyly closed 9 months ago
What this PR contains:
setup.py
in profit of pyproject.toml
pkg_resources
in profit of importlib
(better forward compatibility)Hey @montyly any updates on when this is expected to be merged?
[!WARNING]
Rate Limit Exceeded
@montyly has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 51 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 2fb904ffaa9a5c2613ea7dc2dee97a46ccdfe948 and 034dff1616d2fcdb957df91a0cdb20fffcdb9f66.
The recent updates focus on modernizing Python workflows and dependency management across various GitHub Actions, including transitioning to Python 3.9, enhancing test coverage with a matrix strategy for multiple Python versions, and adopting importlib.metadata
over pkg_resources
for version and entry point handling. Additionally, the setup.py
configuration has been streamlined to simplify package setup, reflecting a shift towards more efficient and maintainable project configurations.
Files | Change Summary |
---|---|
.github/workflows/.../darglint.yml , .github/workflows/.../linter.yml |
Updated Python version from 3.8 to 3.9. |
.github/workflows/pytest.yml |
Changed workflow name to "Pytest", added matrix strategy for Python versions. |
.github/workflows/pytest310.yml |
Switched from python setup.py install to pip install . . |
.github/workflows/tests.yml |
Introduced matrix strategy for Python versions. |
setup.py |
Modified import statement and replaced setup configuration with setuptools.setup() . |
tealer/__main__.py , tealer/utils/.../common.py |
Replaced pkg_resources.require and pkg_resources with importlib.metadata.version and importlib.metadata , added _get_entry_points function. |
🐇✨
In a burrow, deep and wide,
Changes surge like the tide.
Python versions, new and bright,
CodeRabbit hops with delight!
🌟📦
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@aorumbayev : it's available on pypi. The support for 3.12 took us a bit more time than anticipated
Summary by CodeRabbit
python setup.py install
topip install .
for a more standard approach to installing dependencies.pkg_resources.require
withimportlib.metadata.version
for version retrieval, enhancing the efficiency of internal operations.importlib.metadata
, improving compatibility with different Python versions.